Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix arcade dependencies for RemoteExecutor and XunitExtensions packages #929

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

akoeplinger
Copy link
Member

They were misconfigured and not tracked by Version.Details.xml. Also remove unused Build.Tasks.Packaging and .Templating dependencies.

/cc @danmoseley

They were misconfigured and not tracked by Version.Details.xml.
Also remove unused Build.Tasks.Packaging and .Templating dependencies.
@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Nov 17, 2023
@danmoseley
Copy link
Member

Thanks! Does dependabot need telling to ignore them?

@danmoseley danmoseley merged commit 8a7b625 into dotnet:main Nov 17, 2023
3 checks passed
@akoeplinger akoeplinger deleted the fix-versions-xml branch November 17, 2023 16:02
@akoeplinger
Copy link
Member Author

I think it won't touch these packages since it probably can't follow the msbuild property to Version.props

@danmoseley
Copy link
Member

It successfully follows the MSBuild property in the packages.props when it updates them.

I guess we will see

@akoeplinger
Copy link
Member Author

It could have special knowledge about Directory.Packages.props but yeah let's see

@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-codeflow for labeling automated codeflow. intentionally a different color!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants