Service Discovery: fix shutdown blocking indefinitely in some cases #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
approved these changes
Nov 16, 2023
src/Microsoft.Extensions.ServiceDiscovery/Http/HttpServiceEndPointResolver.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Extensions.ServiceDiscovery/Http/HttpServiceEndPointResolver.cs
Outdated
Show resolved
Hide resolved
…ointResolver.cs Co-authored-by: Eric Erhardt <[email protected]>
eerhardt
approved these changes
Nov 16, 2023
|
@ReubenBond - did the build and tests run on this before you merged? It doesn't look like it to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic used to determine when it was safe to dispose was not triggering because we added an additional flag which was not covered by the count mask.