Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't inject bindings at manifest generation for worker projects. #859

Merged
merged 4 commits into from
Nov 27, 2023

Conversation

mitchdenny
Copy link
Member

Fixes #743

We will now scan the project file Sdk to ensure that it is a web project, and only then will we automatically inject the service bindings.

@danmoseley danmoseley added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Nov 16, 2023
@davidfowl
Copy link
Member

Can we instead enrich IServiceMetadata generation?

@mitchdenny
Copy link
Member Author

Can we instead enrich IServiceMetadata generation?

Funny you say that ... I was thinking exactly the same thing this evening as I was making dinner!

@mitchdenny
Copy link
Member Author

Actually we need to support the scenario where multiple SDKs are referenced. Uncommon, but possible.

@davidfowl
Copy link
Member

@mitchdenny when you are back can you prioritize this one?

@mitchdenny
Copy link
Member Author

mitchdenny commented Nov 27, 2023

@davidfowl I'm not so certain looking at the SDK being used is good indicator of whether a project should have bindings automatically generated. I'm thinking it might be better to look at launchSettings.json and determine whether a app URL is present or not.

Updated to code to do this for now since I think it is actually safer, and I think the MSBuild path might be a bit of a dead-end if my understanding of what we can get out of the <MSBuild /> task is correct (and even then I am not convinced its desirable).

@mitchdenny mitchdenny merged commit 15c4446 into main Nov 27, 2023
3 checks passed
@mitchdenny mitchdenny deleted the worker-support branch November 27, 2023 04:42
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Worker projects get generated with http and https bindings
5 participants