-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't inject bindings at manifest generation for worker projects. #859
Conversation
src/Aspire.Hosting/Publishing/AutomaticManifestPublisherBindingInjectionHook.cs
Outdated
Show resolved
Hide resolved
Can we instead enrich IServiceMetadata generation? |
Funny you say that ... I was thinking exactly the same thing this evening as I was making dinner! |
Actually we need to support the scenario where multiple SDKs are referenced. Uncommon, but possible. |
81617c1
to
44a7413
Compare
@mitchdenny when you are back can you prioritize this one? |
…nto backport-701
@davidfowl I'm not so certain looking at the SDK being used is good indicator of whether a project should have bindings automatically generated. I'm thinking it might be better to look at Updated to code to do this for now since I think it is actually safer, and I think the MSBuild path might be a bit of a dead-end if my understanding of what we can get out of the |
Fixes #743
We will now scan the project file Sdk to ensure that it is a web project, and only then will we automatically inject the service bindings.