Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use badge to indicate stderror rather than red text #83

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Use badge to indicate stderror rather than red text #83

merged 1 commit into from
Oct 5, 2023

Conversation

tlmii
Copy link
Member

@tlmii tlmii commented Oct 5, 2023

Since stderr isn't always used for logs that are considered errors (see prometheus logs, which are 100% stderr, as an example), coloring those logs red doesn't feel right. That said, we still want some indication that they came from stderr as opposed to stdout.

This PR adds a badge at the front of the log entry to indicate it comes from stderr. The badge is not selectable (so if the user highlights the logs to copy/paste, they won't get the "stderr" text as part of that).

@tlmii
Copy link
Member Author

tlmii commented Oct 5, 2023

Example:
image

Some discussion about whether the badge should be red to still sort of indicate error... but we're starting with the accent color first and we'll see what feedback we get.

Copy link
Member

@karolz-ms karolz-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fantastic!

@tlmii tlmii merged commit 3807769 into dotnet:main Oct 5, 2023
4 checks passed
@tlmii tlmii deleted the dev/stderr-log-rendering branch October 5, 2023 20:06
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants