Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release/8.0-preview1] Fix default manifest publish (#725) #728

Merged
merged 1 commit into from
Nov 7, 2023
Merged

[release/8.0-preview1] Fix default manifest publish (#725) #728

merged 1 commit into from
Nov 7, 2023

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Nov 7, 2023

No description provided.

@danmoseley
Copy link
Member

Presumably we need @joperezr to kick off a build with this? How does it show up to users?

@eerhardt
Copy link
Member Author

eerhardt commented Nov 7, 2023

How does it show up to users?

If you dotnet publish the AppHost without specifying the publisher it doesn't publish the manifest.

@danmoseley danmoseley merged commit 0e12fb9 into release/8.0-preview1 Nov 7, 2023
6 checks passed
@danmoseley danmoseley deleted the Port725 branch November 7, 2023 19:51
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danmoseley danmoseley danmoseley approved these changes

@baronfel baronfel baronfel approved these changes

@DamianEdwards DamianEdwards DamianEdwards approved these changes

@davidfowl davidfowl Awaiting requested review from davidfowl

@joperezr joperezr Awaiting requested review from joperezr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eerhardt @danmoseley @DamianEdwards @baronfel