Add package descriptions and icons. #701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
reviewed
Nov 6, 2023
src/Aspire.Hosting.Azure.Provisioning/Aspire.Hosting.Azure.Provisioning.csproj
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Nov 6, 2023
davidfowl
reviewed
Nov 6, 2023
Co-authored-by: David Fowler <[email protected]>
davidfowl
reviewed
Nov 6, 2023
Co-authored-by: David Fowler <[email protected]>
Co-authored-by: David Fowler <[email protected]>
Co-authored-by: David Fowler <[email protected]>
davidfowl
reviewed
Nov 6, 2023
src/Microsoft.Extensions.ServiceDiscovery/Microsoft.Extensions.ServiceDiscovery.csproj
Outdated
Show resolved
Hide resolved
Co-authored-by: David Fowler <[email protected]>
davidfowl
reviewed
Nov 6, 2023
src/Aspire.Hosting.Azure.Provisioning/Aspire.Hosting.Azure.Provisioning.csproj
Outdated
Show resolved
Hide resolved
davidfowl
added a commit
that referenced
this pull request
Nov 7, 2023
* Add package descriptions and icons. (#701) * Add package descriptions and icons. * Update src/Microsoft.Extensions.ServiceDiscovery/Microsoft.Extensions.ServiceDiscovery.csproj Co-authored-by: Eric Erhardt <[email protected]> * Update src/Microsoft.Extensions.ServiceDiscovery.Dns/Microsoft.Extensions.ServiceDiscovery.Dns.csproj Co-authored-by: Reuben Bond <[email protected]> * Update src/Microsoft.Extensions.ServiceDiscovery/Microsoft.Extensions.ServiceDiscovery.csproj Co-authored-by: Reuben Bond <[email protected]> * Fix package icons. Use base arcade icon for ServiceDiscovery packages. Use the default Aspire icon for Aspire Hosting packages. --------- Co-authored-by: David Fowler <[email protected]> Co-authored-by: Eric Erhardt <[email protected]> Co-authored-by: Reuben Bond <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used generic Aspire icons for Aspire packages and .NET icons for service discovery pages. Descriptions are an initial proposal, feel free to add alternative text :)
Fixes #700