Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Last round of triple slash, I believe. #661

Merged
merged 4 commits into from
Nov 2, 2023
Merged

Last round of triple slash, I believe. #661

merged 4 commits into from
Nov 2, 2023

Conversation

IEvangelist
Copy link
Member

@IEvangelist IEvangelist commented Nov 2, 2023

I did another round of triple slash additions.

  • Fixed typos, in type names, comments, and variables.
  • Moved a couple classes into their own file, while adding triple slash for them.
  • Remove all /en-us locales from learn.microsoft.com links as it's not supposed to be included.

@davidfowl
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@davidfowl
Copy link
Member

@eerhardt and @ReubenBond take a look at the component and service discovery changes. I'm going to merge this soon and backport to preview1

@davidfowl davidfowl merged commit 3bc2b3a into dotnet:main Nov 2, 2023
5 checks passed
@smitpatel smitpatel deleted the more-triple-slash branch November 2, 2023 17:07
davidfowl added a commit that referenced this pull request Nov 2, 2023
* Last round of triple slash, I believe.

* Revert Aspire.sln change

* Update src/Aspire.Hosting.Azure.Provisioning/UserSecretsPathHelper.cs

* Update src/Aspire.Hosting.Azure.Provisioning/UserSecretsPathHelper.cs

---------

Co-authored-by: David Fowler <[email protected]>
eerhardt pushed a commit that referenced this pull request Nov 2, 2023
* Last round of triple slash, I believe.

* Revert Aspire.sln change

* Update src/Aspire.Hosting.Azure.Provisioning/UserSecretsPathHelper.cs

* Update src/Aspire.Hosting.Azure.Provisioning/UserSecretsPathHelper.cs

---------

Co-authored-by: David Pine <[email protected]>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants