[release/9.0] Update Azure.Provisioning to latest #6489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
requested review from
radical,
eerhardt and
mitchdenny
as code owners
|
/azp run dotnet.aspire |
|
Azure Pipelines successfully started running 1 pipeline(s). |
github-actions
bot
force-pushed
the
backport/pr-6390-to-release/9.0
branch
2 times, most recently
from
b8fa9af to
eaffd06
Compare
Respond to latest renames getting the API ready for GA release. Fix #6376
This hits an issue with `${null}` that is being fixed with Azure/azure-sdk-for-net#46742.
…has a dash. In .NET Aspire 8.x, when the Aspire resource name has dashes, we used those dashes in the Azure resource name. But we are incorrectly converting them to underscores. Fix #6474
github-actions
bot
force-pushed
the
backport/pr-6390-to-release/9.0
branch
from
eaffd06 to
2e9d07b
Compare
|
We knew this is coming and it is needed for the release. Approved. |
|
@eerhardt let me know when this is ready to merge. |
davidfowl
approved these changes
Oct 25, 2024
|
/azp run dotnet.aspire |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@eerhardt were you planning to make more changes here or is this ready to go? |
We just got the stable packages pushed to nuget.org. I'm updating this with the stable dependencies and removing the nuget.config entries. Then it will be ready to merge. UPDATE: I see you did part of this above. I just need to remove the test nuget.config changes. |
eerhardt
approved these changes
Oct 26, 2024
|
Let’s gooo |
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #6390 to release/9.0
/cc @eerhardt
Customer Impact
We need to use the GA version of the Azure.Provisioning libraries, so we can ship our
Aspire.Hosting.Azure*packages as stable.Also fix an issue when using dashes
-in resource names and usingAspireV8ResourceNamePropertyResolver. We are prematurely converting the dash to an underscore, and the Azure resource name is not the same as it was in v8. This needs to be fixed together with this change because the APIs we need to fix the issue are being made public in this new Azure.Provisioning version.Fix #6474
Testing
Automated unit tests in repo still pass with the same bicep output.
Risk
There is some low risk in the new version of Azure.Provisioning, but all our tests are passing.
Regression?
No
Microsoft Reviewers: Open in CodeFlow