Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add executable logs #64

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Add executable logs #64

merged 1 commit into from
Oct 5, 2023

Conversation

smitpatel
Copy link
Contributor

dapr sample runs executable for logs. Though in real testing doesn't look like executables are running correctly

Resolves https://github.com/dotnet/aspire-private-planning/issues/682

dapr sample runs executable for logs. Though in real testing doesn't look like executables are running correctly

Resolves https://github.com/dotnet/aspire-private-planning/issues/682
Copy link
Member

@karolz-ms karolz-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

View model changes look good. I will let @tlmii comment on the UI changes. I was expecting more reuse between Project and Executable logs, but maybe I am missing some complicating factors.

@smitpatel
Copy link
Contributor Author

I was intending to refactor common parts once we have pieces in place. 😃

@davidfowl
Copy link
Member

I was expecting more reuse between Project and Executable logs

Looking forward to the clean up! Please merge ASAP 😄

Copy link
Member

@tlmii tlmii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidfowl davidfowl merged commit d5d98a4 into main Oct 5, 2023
4 checks passed
@davidfowl davidfowl deleted the smit/executableslogs branch October 5, 2023 05:07
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants