Increase docker command timeout #591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Docker goes to into resource saver mode after 5 minutes of not running a container (by default). While in this mode, the commands we use for the docker check take quite some time (11+ seconds on my laptop). Increasing the timeout for 25 seconds instead. Read more here: https://docs.docker.com/desktop/use-desktop/resource-saver/
JamesNK
reviewed
Oct 31, 2023
Co-authored-by: James Newton-King <[email protected]>
karolz-ms
approved these changes
Oct 31, 2023
|
/backport to release/8.0-preview1 |
|
Started backporting to release/8.0-preview1: https://github.com/dotnet/aspire/actions/runs/6712252537 |
|
@davidfowl backporting to release/8.0-preview1 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Patch format detection failed.
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@davidfowl an error occurred while backporting to release/8.0-preview1, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
|
Why does this bot suck 😄 |
davidfowl
added a commit
that referenced
this pull request
Oct 31, 2023
* Increase docker command timeout Docker goes to into resource saver mode after 5 minutes of not running a container (by default). While in this mode, the commands we use for the docker check take quite some time (11+ seconds on my laptop). Increasing the timeout for 25 seconds instead. Read more here: https://docs.docker.com/desktop/use-desktop/resource-saver/ * Update src/Aspire.Hosting/Dcp/DcpHostService.cs Co-authored-by: James Newton-King <[email protected]> --------- Co-authored-by: James Newton-King <[email protected]>
davidfowl
added a commit
that referenced
this pull request
Nov 1, 2023
* Increase docker command timeout Docker goes to into resource saver mode after 5 minutes of not running a container (by default). While in this mode, the commands we use for the docker check take quite some time (11+ seconds on my laptop). Increasing the timeout for 25 seconds instead. Read more here: https://docs.docker.com/desktop/use-desktop/resource-saver/ * Update src/Aspire.Hosting/Dcp/DcpHostService.cs --------- Co-authored-by: James Newton-King <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker goes to into resource saver mode after 5 minutes of not running a container (by default). While in this mode, the commands we use for the docker check take quite some time (11+ seconds on my laptop). Increasing the timeout for 25 seconds instead.
Read more here:
https://docs.docker.com/desktop/use-desktop/resource-saver/