Support connection name-based configuration for Azure components #5827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
captainsafia
requested review from
radical,
eerhardt and
sebastienros
as code owners
captainsafia
force-pushed
the
safia/funcs-dual-config
branch
from
9f23492
to
fb751a4
Compare
davidfowl
reviewed
Sep 22, 2024
playground/AzureFunctionsEndToEnd/AzureFunctionsEndToEnd.Functions/MyHttpTrigger.cs
Outdated
Show resolved
Hide resolved
Test Log |
Yeah, I pulled a goofy pushing this commit without testing locally 🙊 We'll have to figure out how to inject the Functions-specific
|
eerhardt
reviewed
Sep 23, 2024
| BindSettingsToConfiguration(settings, configSection); | ||
| BindSettingsToConfiguration(settings, configSection.GetSection(connectionName)); |
There was a problem hiding this comment.
Why are we only doing this for Azure client libraries? Shouldn't we be doing it for all, so they are consistent?
There was a problem hiding this comment.
Capturing offline discussion, we'll do this for all integrations but prioritizing Azure components and dependencies for Functions in this PR.
eerhardt
reviewed
Sep 23, 2024
davidfowl
reviewed
Sep 24, 2024
Open
3 tasks
eerhardt
reviewed
Sep 25, 2024
playground/AzureFunctionsEndToEnd/AzureFunctionsEndToEnd.ApiService/Program.cs
Outdated
Show resolved
Hide resolved
src/Aspire.Hosting.Azure.Functions/AzureFunctionsProjectResourceExtensions.cs
Show resolved
Hide resolved
captainsafia
force-pushed
the
safia/funcs-dual-config
branch
from
7b30329
to
fe0b889
Compare
eerhardt
reviewed
Sep 27, 2024
eerhardt
approved these changes
Sep 27, 2024
captainsafia
force-pushed
the
safia/funcs-dual-config
branch
from
fe0b889
to
1504c91
Compare
captainsafia
added
the
area-integrations
captainsafia
added
the
azure-functions
4 tasks
16 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds support for named configuration providers to Azure components and updates resource types that implement
IResourceWithAzureFunctionsconfig to inject values into configuration model.Microsoft.Azure.Functions.Worker.Extensions.Http.AspNetCoreto version2.0.0-preview1to use newFunctionsWebApplicationBuilderimplementation so we can take advantage ofIHostApplicationBuilder-based extension methods for integrations.IResourceWithAzureFunctionsConfigto inject named configuration values into environment variables.AzureComponentto support binding settings from named configuration providers.Checklist
<remarks />and<code />elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow