Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor style improvements #5678

Merged
merged 4 commits into from
Sep 11, 2024
Merged

Minor style improvements #5678

merged 4 commits into from
Sep 11, 2024

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Sep 11, 2024

Description

Some minor style improvements

  • Hide 3rd trace label instead of the last trace label
  • Row gap for toolbar wrapping

Before:
image

After:
image

image

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

<div class="tick" style="grid-column: 4;"></div>
<span class="tick-label" style="grid-column: 4;">@DurationFormatter.FormatDuration(trace.Duration / 4 * 3)</span>
@if (_manager.ViewportInformation.IsDesktop)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using this instead of hidden-on-mobile so it works when details view is open.

@adamint adamint merged commit 933fdf7 into main Sep 11, 2024
12 checks passed
@adamint adamint deleted the jamesnk/style-improvements branch September 11, 2024 17:00
@github-actions github-actions bot locked and limited conversation to collaborators Oct 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants