Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make volume icon size consistent with other inline icons #5644

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Sep 10, 2024

Description

Fixes #5635

Make this icon the same size as other icons inline with standard text: state icon on resources page and error/warning/exception icons on structured logs page.

Before:
image

After:
image

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

@JamesNK JamesNK changed the title Make volume icon size consistent with state icon size Make volume icon size consistent with other inline icons Sep 10, 2024
@JamesNK
Copy link
Member Author

JamesNK commented Sep 13, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@JamesNK JamesNK merged commit f7f5645 into main Sep 13, 2024
11 checks passed
@JamesNK JamesNK deleted the jamesnk/volume-icon branch September 13, 2024 06:10
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Volume readonly icon too small
2 participants