Allow Dashboard application to roll-forward #5540
Conversation
| application is not able to run if the place where it is deployed does not have the .NET 8.0 runtime installed. | ||
| Given we want to be able to support people running on environments where they only have the 9.0 SDK/runtime installed, | ||
| we allow roll-forward to the next major in order to support these customers.--> | ||
| <RollForward>Major</RollForward> |
There was a problem hiding this comment.
I wrote in the description, the plan is that once we add 9.0 templates (@radical is working on it) we'll be adding tests specifically for environments with only 9.0 SDK installed (to validate that 9.0 templates can be created and built), so at that time we'll be able to add a test for this by using the 9.0 SDK to create a template, run it, and then validate that the dashboard is loading correctly.
There was a problem hiding this comment.
Do we also want to run the Dashboard tests on net9? "validate that the dashboard is loading correctly" is a good first step, but it won't cover all the use cases of the dashboard.
There was a problem hiding this comment.
We can certainly consider it, but not sure if we would get a lot from it so perhaps we can consider doing it in a format similar to runtime's outerloop runs (run once a day maybe?). Point being those tests would mostly be trying to catch breaking changes between 8.0 and 9.0, which while they are very possible, I'm guessing it is not something that may add a lot of value on testing on each CI run.
There was a problem hiding this comment.
My above suggestion for "is it loading correctly" was simply to validate that the property is doing it's job and the 9.0 runtime is effectively being able to run the dashboard to begin with.
|
@eerhardt any other comments or is this good to go? It would be good to include in 9.0 preview 4, which is why I ask |
|
How can this be tested locally? |
|
The way I did it, was:
In the above case, the dashboard would still be targeting 8.0 but the SDK you are using doesn't have that runtime installed, but the dashboard is still able to run due to the rollForward policy. |
|
/backport to release/9.0-preview4 |
|
Started backporting to release/9.0-preview4: https://github.com/dotnet/aspire/actions/runs/10778910439 |
|
/backport to release/8.2 |
|
Started backporting to release/8.2: https://github.com/dotnet/aspire/actions/runs/11448087732 |
Description
In order to better support customers that only have the 9.0 SDK/Runtime installed, we will allow the Dashboard application to roll-forward to the next major, which would then not require the 8.0 runtime to also be installed in order to run the Aspire Dashboard. I have manually validated that with these changes I am able to run an Aspire application in a machine that only has .NET 9 installed. Automated tests will require having a setup where the 9.0 SDK is used, which will be added by @radical with the planned template work for 9.0. Once that is in place, we can go ahead and add automation for this.
Fixes #5445
Checklist
<remarks />and<code />elements on your triple slash comments?Microsoft Reviewers: Open in CodeFlow