Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test coverage for redis, postgres, containers #551

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Add unit test coverage for redis, postgres, containers #551

merged 2 commits into from
Oct 27, 2023

Conversation

BrennanConroy
Copy link
Member

Next part of #50

davidfowl
davidfowl approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@davidfowl davidfowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit around asserting the number of annotations.

@BrennanConroy BrennanConroy merged commit f117ad3 into main Oct 27, 2023
4 checks passed
@BrennanConroy BrennanConroy deleted the brecon/test2 branch October 27, 2023 21:30
@danmoseley danmoseley added the area-integrations Issues pertaining to Aspire Integrations packages label Nov 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davidfowl davidfowl davidfowl approved these changes

@mitchdenny mitchdenny Awaiting requested review from mitchdenny mitchdenny is a code owner

Assignees
No one assigned
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrennanConroy @davidfowl @danmoseley