New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use static for classes with all static members #5485

Merged

davidfowl merged 1 commit into dotnet:main from SimonCropp:use-static-for-classes-with-all-static-members

Sep 9, 2024

Contributor

SimonCropp commented Aug 29, 2024 •

edited by dotnet-policy-service bot

Loading

i assume there is not a reason these are instance and sealed instead of static?

only internal types

Microsoft Reviewers: Open in CodeFlow


          use static for classes with all static members

389d7ae

SimonCropp requested review from radical, eerhardt, sebastienros and ReubenBond as code owners

August 29, 2024 23:45

dotnet-issue-labeler bot added the area-service-discovery label

dotnet-policy-service bot added the community-contribution label

sebastienros approved these changes

View reviewed changes

davidfowl merged commit d8caaec into dotnet:main

11 checks passed

github-actions bot locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

sebastienros sebastienros approved these changes

radical Awaiting requested review from radical radical is a code owner

eerhardt Awaiting requested review from eerhardt eerhardt is a code owner

ReubenBond Awaiting requested review from ReubenBond ReubenBond is a code owner

Labels

area-service-discovery community-contribution