Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Container ID #544

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Display Container ID #544

merged 1 commit into from
Oct 27, 2023

Conversation

tlmii
Copy link
Member

@tlmii tlmii commented Oct 27, 2023

Resolves #543

ContainerID

@tlmii tlmii enabled auto-merge (squash) October 27, 2023 06:22
@tlmii tlmii merged commit 5331863 into dotnet:main Oct 27, 2023
4 checks passed
@smitpatel smitpatel deleted the dev/container-id branch October 27, 2023 06:57
@smitpatel
Copy link
Contributor

Wouldn't container name be better?

@tlmii
Copy link
Member Author

tlmii commented Oct 27, 2023

Wouldn't container name be better?

@smitpatel Do you mean calling this field "container name" or displaying the container name instead of container id? We don't have the name in the model I don't think? And I thought calling this field "container name" when there's already a name (for the container entry) property was weird so I stuck with container ID since that's what's on the model. Easy to change if we think we should though.

@smitpatel
Copy link
Contributor

I was thinking the friendly name which docker CLI shows. Though can see confusing. We can wait till user feedback.

@tlmii
Copy link
Member Author

tlmii commented Oct 27, 2023

Got it. Yeah, we don't have that in the data model right now as far as I can tell (though it'd seem like we should be able to get it?). Would be a good addition if we can figure out what to call it to differentiate from the Name we already have.

eerhardt pushed a commit that referenced this pull request Oct 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show the underlying docker container name in the containers view
3 participants