Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GridColumnManager improvements #5433

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

drewnoakes
Copy link
Member

@drewnoakes drewnoakes commented Aug 26, 2024

The previous code had two issues that are addressed here:

  • Inconsistent use of string comparers for column names.
  • O(N) scan through the column collection for lookups.

This PR uses a dictionary for columns, which ensures consistent comparer use, and gives O(1) lookup.

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No, covered by existing tests
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No
Microsoft Reviewers: Open in CodeFlow

The previous code had two issues that are addressed here:

- Inconsistent use of string comparers for column names.
- O(N) scan through the column collection for lookups.

This PR uses a dictionary for columns, which ensures consistent comparer use, and gives O(1) lookup.
@drewnoakes drewnoakes merged commit 28e5c75 into dotnet:main Aug 26, 2024
11 checks passed
@drewnoakes drewnoakes deleted the drnoakes/grid-column-manager branch August 26, 2024 05:02
@github-actions github-actions bot locked and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants