Add CORS to OTLP HTTP endpoint #5177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewnoakes
approved these changes
Aug 6, 2024
JamesNK
commented
Aug 6, 2024
JamesNK
force-pushed
the
jamesnk/otlphttp-cors
branch
from
c6e1053
to
1349b71
Compare
|
I changed the configuration to use comma separated strings. Using collection syntax isn't that much nicer in JSON but is much worse via env vars and command line. For example, feels odd when passing a string |
Co-authored-by: Martin Costello <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #4917
Implements 1 & 2 from #4917 (comment)
Microsoft Reviewers: Open in CodeFlow