Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix configuration binding #5173

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Fix configuration binding #5173

merged 3 commits into from
Aug 6, 2024

Commits on Aug 5, 2024

  1. Fix configuration binding 

    The dashboard supports the use of client certificates for authorization to the resource service. This requires a custom resource server, and we're not aware of any that use this feature.

Throughout the Aspire documentation, we advertise values like `Dashboard:ResourceServiceClient:ClientCertificates:Source` to configure certificates, however these values will not bind to the documented configuration values. The CLR property was `ClientCertificates` (plural), not the documented `ClientCertificate` (singular).

This change makes the dashboard respect the documented configuration names.
    @drewnoakes
    drewnoakes committed Aug 5, 2024
    Configuration menu
    Copy the full SHA
    c992927 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2024

  1. Create constants for certificate config names

    @drewnoakes
    drewnoakes committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    8a232c3 View commit details
    Browse the repository at this point in the history

  2. Add startup integration test to cover certificate config

    @drewnoakes
    drewnoakes committed Aug 6, 2024
    Configuration menu
    Copy the full SHA
    1065016 View commit details
    Browse the repository at this point in the history