-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding public API test coverage Aspire.Hosting.NodeJs #5161
Adding public API test coverage Aspire.Hosting.NodeJs #5161
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing check in constructor
https://github.com/dotnet/aspire/blob/main/src/Aspire.Hosting.NodeJs/NodeAppResource.cs
|
Yes, I know, there was just a case message when the name of a parameter differed from the name of the parameter being checked in the ExecutableResource. |
bba4495
to
53d7217
Compare
} | ||
|
||
[Fact] | ||
public void AddNpmAppShouldThrowWhenScriptNameIsNull() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Alirexaa you missed this one. It has a default value but it doesn't mean we still can't call it with a null
value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I had to force push to revert the changes in the .sln file.
…aspire-hosting-nodejs
…aspire-hosting-nodejs
…aspire-hosting-nodejs
Contributes to #2649 and #5047
Microsoft Reviewers: Open in CodeFlow