Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Aspire Workload SDK Band to 8.0.100 #508

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

joperezr
Copy link
Member

This is going to update the Aspire Workload SDK Band to be 8.0.100 instead of 8.0.100-rc.1 as it is currently.

Do note that this change will make it so that updating the workload going forward will require an SDK which has this manifest inserted in it already (The current minimum version noted in this repo only has 8.0.100-rc.1 inserted). After this goes in and we insert this into the SDK, I'll update the instructions in the getting started docs of the repo to point to the new minimum SDK version required for this. There is a workaround in the meantime that can be run once in a machine, and would allow people to continue to update their workload across SDK bands. That workaround will be the one that will need to be used for external folks using the repo (as they won't have access to internal only SDK builds). I will also update the docs once we have a build with these changes to include the workaround instructions.

cc: @dsplaisted @marcpopMSFT @danegsta @DamianEdwards @mhutch

@joperezr joperezr marked this pull request as draft October 25, 2023 23:01
@joperezr
Copy link
Member Author

Marking as draft, as I'm now thinking it would be best to do this in release branch only so as to not disrupt current dogfooding.

@joperezr joperezr changed the base branch from main to release/8.0-preview1 October 25, 2023 23:10
@joperezr
Copy link
Member Author

Okay, synced main into release branch, and retargeted this PR to release branch instead. Marking ready for review.

@joperezr joperezr marked this pull request as ready for review October 25, 2023 23:11
@joperezr
Copy link
Member Author

Merging this in order to unblock the insertion to dotnet/installer. I did chat about this with @dsplaisted offline and we seem to have an agreement on the plan.

@joperezr joperezr merged commit 2b67742 into release/8.0-preview1 Oct 26, 2023
4 checks passed
@joperezr joperezr deleted the joperezr/UpdateWorkloadBand branch October 26, 2023 17:55
@github-actions github-actions bot locked and limited conversation to collaborators Apr 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants