Use cancellation token and increase timeout for docker inspect fetchi… #502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng env vars Resolves #491
tlmii
approved these changes
Oct 25, 2023
| @@ -367,7 +367,7 @@ private async Task ComputeEnvironmentVariablesFromDocker(Container container) | |||
|
|
|||
| (task, processDisposable) = ProcessUtil.Run(spec); | |||
|
|
|||
| var exitCode = (await task.WaitAsync(TimeSpan.FromSeconds(5)).ConfigureAwait(false)).ExitCode; | |||
| var exitCode = (await task.WaitAsync(TimeSpan.FromSeconds(30), cancellationToken).ConfigureAwait(false)).ExitCode; | |||
There was a problem hiding this comment.
Docker really forcing us to true "eventual" consistency it looks like. That's unfortunate we'd need a timeout that long. But its not blocking so seems ok.
There was a problem hiding this comment.
I think my discussion with @karolz-ms it was indicated that docker can take long time. We wait for 10s to verify if docker is running in our startup. Since that is exception code path and this is not, I went with large amount. If we timeout here, we won't retry till cache is invalidated so just being overly generous. Non-blocking nature should help us avoid any impact of this.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ng env vars
Didn't add actual retry as other docker commands don't retry either right now.
Resolves #491
Also addresses PR feedback #429