Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Service Bus tracing #48

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Adjust Service Bus tracing #48

merged 2 commits into from
Oct 4, 2023

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Oct 3, 2023

  • Add Azure.Messaging.ServiceBus and Azure.Messaging.ServiceBus.ServiceBusProcessor activity sources to OTel
  • Removing setting the parentId on the custom activity. This is not needed because ServiceBusProcessor will set the static parent activity.
  • Update Telemetry.md

Here's what a trace of the sample app "check out" process looks like with the current code.

image

- Add Azure.Messaging.ServiceBus and Azure.Messaging.ServiceBus.ServiceBusProcessor activity sources to OTel
- Removing setting the parentId on the custom activity. This is not needed because ServiceBusProcessor will set the static parent activity.
@davidfowl davidfowl merged commit 702ba33 into main Oct 4, 2023
4 checks passed
@davidfowl davidfowl deleted the TweakServiceBusTracing branch October 4, 2023 00:42
@samsp-msft
Copy link
Member

What is the delay before the service bus calls are made - is the parenting correct?

@eerhardt
Copy link
Member Author

eerhardt commented Oct 4, 2023

The above screen shot doesn't show the full trace. There are other operations happening above this one. Here is the full trace:

image

@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants