Make sure that projects with no launch profile can still run #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
approved these changes
Oct 24, 2023
|
Will this break apps until the dcp update? |
|
It should not. The change only affects services without launch profile, and those did not work anyway. |
|
Well they sorta did, 😄. You can work around the issue in the app itself. Or you can set custom service bindings. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for Service application gets dashboard url injected if there's no launch settings. I am not super sure if this is the best fix--please chime in if you can think of something else.
I tested this by deleting all launch settings from eShopLite frontend service. Because there is no launch profile, we do not generate a service binding annotation, and as a result, the frontend does not get a clickable "endpoint" in the dashboard. But one can look at the logs and learn the URL for the frontend there. If you navigate to that URL, the application works fine.
Fixes #225