Limit log and trace telemetry #470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
reviewed
Oct 24, 2023
|
|
||
| namespace Aspire.Dashboard.Otlp.Storage; | ||
|
|
||
| internal sealed class CircularBuffer<T> : IList<T>, ICollection<T>, IEnumerable<T>, IEnumerable |
There was a problem hiding this comment.
@stephentoub Can/Should we use ConcurrentQueueSegment?
There was a problem hiding this comment.
Items are inserted with an order and can arrive out of order, so inserting at a position is required.
JamesNK
force-pushed
the
jamesnk/telemetry-limit-real
branch
from
9c1c1e1
to
583b410
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #419
Limit logs and traces to 10,000 items. Not configurable, but would be simple to add in the future.
TODO: Read value from
IConfiguration.