Allow WithArgs to accept ReferenceExpressions

[afscrome]

Update the WithArgs extension method to accept object[] rather than string[]. In particular, this now allows for the use of reference expressions inside WithArgs

.WithArgs(
   "-p",
   resource.PrimaryEndpoint.Property(EndpointProperty.TargetPort)
);

Fixes #4237

Microsoft Reviewers: Open in CodeFlow

[davidfowl]

@afscrome are you going to fix this PR?

[afscrome]

Hoping to pick this up over the weekend unless someone else wants to take it before then.

Also spotted earlier today that a similar addition is probably warranted for public static IResourceBuilder<ExecutableResource> AddExecutable(this IDistributedApplicationBuilder builder, string name, string command, string workingDirectory, params string[]? args)

[afscrome]

There is a similar issue with WithContainerRuntimeArgs. Whilst the underlying ContainerRuntimeArgsCallbackContext has arguments as a list of objects

aspire/src/Aspire.Hosting/ApplicationModel/ContainerRuntimeArgsCallbackAnnotation.cs

Line 56 in a891b99

public IList<object> Args { get; } = args ?? throw new ArgumentNullException(nameof(args));

ContainerResourceBuilderExtensions.WithContainerRuntimeArgs only accepts a string array

aspire/src/Aspire.Hosting/ContainerResourceBuilderExtensions.cs

Lines 183 to 186 in a891b99

	public static IResourceBuilder<T> WithContainerRuntimeArgs<T>(this IResourceBuilder<T> builder, params string[] args) where T : ContainerResource
	{
	return builder.WithContainerRuntimeArgs(context => context.Args.AddRange(args));
	}

Shall I fix that as well?

[afscrome]

Any ideas on how to fix the ambiguity this change introduces between

public static IResourceBuilder<ExecutableResource> AddExecutable(this IDistributedApplicationBuilder builder, string name, string command, string workingDirectory, params string[]? args)
public static IResourceBuilder<ExecutableResource> AddExecutable(this IDistributedApplicationBuilder builder, string name, string command, string workingDirectory, params object[]? args)

I could remove the params from the string[] version, but according to https://github.com/dotnet/runtime/blob/main/docs/coding-guidelines/breaking-change-rules.md#signatures that is a breaking change, or does the addition of the params object[] version mitigate that break?

But equally if I remove the params from the object[] version, that would somewhat defeat the point of the addition.

[eerhardt]

@afscrome - it looks like we were using an older SDK - 8.0.200. I updated to the latest .NET SDK 8.0.302 and the build error should be fixed now. You can overload methods on params arrays of different types. So we should be good.

[afscrome]

@eerhardt Can this be merged now? I've resolved the merge conflicts and checks are all passing.

[eerhardt]

@eerhardt Can this be merged now? I've resolved the merge conflicts and checks are all passing.

Can you add some tests for the new functionality?

[davidfowl]

@afscrome Are you going to finish this one?

[afscrome]

Updated tests to cover the new scenarios.