Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove AspNetCore dependency in Npgsql EF Core component #427

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Conversation

eerhardt
Copy link
Member

The Npgsql EF Core component currently adds the EF developer page in development environments. This means the Npgsql EF Core component is dependent on the ASP.NET Core shared framework, which brings more dependencies on it in other app models (ex. Worker apps).

Removing this functionality because this dependency is not desirable and we don't have it in the SQL Server component.

Fix #146

The Npgsql EF Core component currently adds the EF developer page in development environments. This means the Npgsql EF Core component is dependent on the ASP.NET Core shared framework, which brings more dependencies on it in other app models (ex. Worker apps).

Removing this functionality because this dependency is not desirable and we don't have it in the SQL Server component.

Fix #146
@DamianEdwards
Copy link
Member

@davidfowl where are you on this right now? You said again today "all apps are web apps" due to them needing health checks endpoints.

@eerhardt
Copy link
Member Author

"all apps are web apps" due to them needing health checks endpoints.

They don't need health checks endpoints. Specifically Worker apps can't have them since they don't have a WebApplication to pass into MapDefaultEndpoints.

You can configure health checks to run in a HostedService and periodically check health and log it. https://learn.microsoft.com/en-us/aspnet/core/host-and-deploy/health-checks?view=aspnetcore-7.0#health-check-publisher

@DamianEdwards
Copy link
Member

They need health checks endpoints if the environment only supports endpoints for probing though right?

@eerhardt
Copy link
Member Author

They need health checks endpoints if the environment only supports endpoints for probing though right?

If they need to expose HTTP endpoints, then they aren't "Worker" apps anymore.

@davidfowl
Copy link
Member

@davidfowl where are you on this right now? You said again today "all apps are web apps" due to them needing health checks endpoints.

I think this decoupling is fine.

@eerhardt eerhardt merged commit be1c18b into main Oct 23, 2023
4 checks passed
@eerhardt eerhardt deleted the Fix146 branch October 23, 2023 13:32
@danmoseley danmoseley added the area-integrations Issues pertaining to Aspire Integrations packages label Nov 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EF.PostgreSQL component depends on ASP.NET Core shared framework
4 participants