[release/8.0] Testing: Do not configure HttpClient resilience by default #3846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-issue-labeler
bot
added
the
area-app-model
dotnet-policy-service
bot
added
the
Servicing-consider
danmoseley
added
Servicing-approved
DamianEdwards
approved these changes
Apr 19, 2024
RussKie
approved these changes
Apr 19, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3845 to release/8.0
/cc @ReubenBond
Customer Impact
This affects customers using the Aspire.Hosting.Testing package. Without this change,
HttpClientinstances resolved from the test host's service provider will have resiliency enabled by default. This PR removes that because resilience is not straightforward to configure after it has been added today (there is an issue tracking this on dotnet/extensions. See the original PR)Testing
We have existing automated tests which exercise this code-path, but they do not test the presence or absence of resilience specifically.
Risk
Very small: users can always add this functionality back themselves with a one-liner. The default behavior is acceptable
Regression?
No
Microsoft Reviewers: Open in CodeFlow