Add callback to WithPgAdmin to allow customization. #3801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-app-model
mitchdenny
added
the
breaking-change
davidfowl
approved these changes
Apr 18, 2024
mitchdenny
added a commit
that referenced
this pull request
Apr 18, 2024
* Add callback to WithPgAdmin to allow customization. * Fix const names.
| /// <param name="builder">The resource builder for PGAdmin.</param> | ||
| /// <param name="port">The port to bind on the host. If null is used random port will be assigned.</param> | ||
| /// <returns>The resource builder for PGAdmin.</returns> | ||
| public static IResourceBuilder<PgAdminContainerResource> UseHostPort(this IResourceBuilder<PgAdminContainerResource> builder, int? port) |
There was a problem hiding this comment.
This is new right? Are we sure Use is the right prefix here? Seems odd that this method is only available for this resource type.
There was a problem hiding this comment.
It's what we do with the other azure resources that have emulators:
RussKie
pushed a commit
that referenced
this pull request
Apr 19, 2024
* Fix WithEnvironment with wrong type constraint. (#3750) * Add WithDataVolume() and WithDataBindMount() APIs to Seq. (#3762) * Add WithDataVolume() and WithDataBindMount() APIs to Seq. * Add callback to WithPgAdmin to allow customization. (#3801) * Add callback to WithPgAdmin to allow customization. * Fix const names. * Fixed NATS volume mounts (#3763) * Fixed NATS volume mounts --------- Co-authored-by: Ziya Suzen <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #3770
This PR modifies the arguments for
WithPgAdminto take a callback which allows for a greater array of customization. Usage example:Microsoft Reviewers: Open in CodeFlow