Add Cache-Control: no-cache; to Static Web Assets #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
approved these changes
Oct 3, 2023
smitpatel
reviewed
Oct 3, 2023
| // ETag and Last-Modified headers will be respected by the browser. | ||
| // This may be able to be removed if https://github.com/dotnet/aspnetcore/issues/44153 | ||
| // is fixed to make this the default | ||
| if (context.Context.Response.Headers.CacheControl.Count == 0) |
There was a problem hiding this comment.
Should we do this only in dev env?
There was a problem hiding this comment.
I think it is relevant regardless isn't it? If the user updates their Aspire.Dashboard nuget package, the URL for, say, LogViewer.razor.js in the browser will still be the same and possibly cached, no matter what environment is set.
There was a problem hiding this comment.
Yeah I agree - without this header, the same caching issues would occur in prod too, which is worse still.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dotnet/astra/issues/705.
Static Web Assets middleware currently sets the ETag and Last-Modified headers, but it does not set the Cache-Control header to no-cache. This means that in some (many? most?) cases the browser ignores the ETag and Last-Modified headers and always pulls the asset from cache.
dotnet/aspnetcore#44153 has been re-opened to potentially address this in the middleware itself. But for now, we can use the
StaticFileOptionsparameter ofUseStaticFilesto add the header ourself if we see that it's not set to anything else.