Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gRPC calls to not use NotFound status #361

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Oct 18, 2023

Fixes #116

After the change there are no error spans from missing cart:
image

@JamesNK JamesNK enabled auto-merge (squash) October 18, 2023 02:13
@JamesNK JamesNK merged commit 7d0267e into main Oct 18, 2023
4 checks passed
@JamesNK JamesNK deleted the jamesnk/grpc-no-error branch October 18, 2023 02:18
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sample: Change gRPC services to not create errored spans
2 participants