Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stay on the sync context when rendering console logs #3459

Merged
merged 2 commits into from
Apr 7, 2024
Merged

Stay on the sync context when rendering console logs #3459

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f20aa5b
Stay on the sync context when rendering console logs
davidfowl Apr 6, 2024
17a053a
PR feedback
davidfowl Apr 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/Aspire.Dashboard/Components/Controls/LogViewer.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,8 @@ internal async Task SetLogSourceAsync(IAsyncEnumerable<IReadOnlyList<ResourceLog
var cancellationToken = await _cancellationSeries.NextAsync();
var logParser = new LogParser();

await foreach (var batch in batches.WithCancellation(cancellationToken).ConfigureAwait(false))
// This needs to stay on the UI thread since we raise StateHasChanged() in the loop (hence the ConfigureAwait(true)).
await foreach (var batch in batches.WithCancellation(cancellationToken).ConfigureAwait(true))
{
if (batch.Count is 0)
{
Expand Down
Loading