Do not set TargetPort to Port when IsProxying is also set

[ReubenBond]

When creating endpoint annotations, if a TargetPort is equal to the Port for a non-Container resource (and non-null) and IsProxying is true, that is an error: DCP cannot bind a proxy to a port which the target service is also bound to.

This PR does two things:

1. We do not set TargetPort to Port automatically if IsProxying is true.
2. If the resource is not a container and TargetPort == Port && IsProxying, then we throw during startup

Microsoft Reviewers: Open in CodeFlow

[eerhardt]

LGTM

[davidfowl]

Can you re gen the manifests? I want to see if there are any changes

[davidfowl]

cc @vhvb1989

[ReubenBond]

Can you re gen the manifests?

Is there a way to do that across all projects? We have some tests which check manifest output and they did not change

[eerhardt]

Can you re gen the manifests?

Is there a way to do that across all projects? We have some tests which check manifest output and they did not change

We should really add an official way to do it to the repo, but here's a hack powershell script that I used a few weeks ago:

$playground_apps = @(
    "C:\git\aspire2\playground\AWS\AWS.AppHost\",
    "C:\git\aspire2\playground\AzureSearchEndToEnd\AzureSearch.AppHost\",
    "C:\git\aspire2\playground\AzureStorageEndToEnd\AzureStorageEndToEnd.AppHost\",
    "C:\git\aspire2\playground\bicep\BicepSample.AppHost\",
    "C:\git\aspire2\playground\cdk\CdkSample.AppHost\",
    "C:\git\aspire2\playground\CosmosEndToEnd\CosmosEndToEnd.AppHost\",
    "C:\git\aspire2\playground\CustomResources\CustomResources.AppHost",
    "C:\git\aspire2\playground\dapr\AppHost\",
    "C:\git\aspire2\playground\DatabaseMigration\DatabaseMigration.AppHost",
    "C:\git\aspire2\playground\mongo\Mongo.AppHost\",
    "C:\git\aspire2\playground\mysql\MySqlDb.AppHost\",
    "C:\git\aspire2\playground\nats\Nats.AppHost\",
    "C:\git\aspire2\playground\OpenAIEndToEnd\OpenAIEndToEnd.AppHost\",
    "C:\git\aspire2\playground\orleans\OrleansAppHost",
    "C:\git\aspire2\playground\ParameterEndToEnd\ParameterEndToEnd.AppHost\",
    "C:\git\aspire2\playground\PostgresEndToEnd\PostgresEndToEnd.AppHost\",
    "C:\git\aspire2\playground\ProxylessEndToEnd\ProxylessEndToEnd.AppHost\",
    "C:\git\aspire2\playground\seq\Seq.AppHost\",
    "C:\git\aspire2\playground\signalr\SignalRAppHost\",
    "C:\git\aspire2\playground\SqlServerEndToEnd\SqlServerEndToEnd.AppHost\",
    "C:\git\aspire2\playground\TestShop\AppHost\")

foreach ($playground_app in $playground_apps)
{
Push-Location $playground_app
dotnet run -- --publisher manifest --output-path aspire-manifest.json
Pop-Location
}

[ReubenBond]

I ran the script and compared main vs prior to this commit and got the same results.