-
Notifications
You must be signed in to change notification settings - Fork 475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template updates #31
Template updates #31
Conversation
src/Aspire.ProjectTemplates/templates/aspire-starter/.template.config/template.json
Outdated
Show resolved
Hide resolved
It looks like this should be working. One thing to note that if you were applying these changes to the template.json locally, (dotnet new install) you may be running into cache issues. Try: dotnet new uninstall [path] cache issues are only a problem when editing template metadata in place, you can generally get away with updating content without the uninstall/launch/install loop |
Can you confirm that Web API -> Enlist in Aspire Orchestration still works after this? I'm not sure if the sln file is going to be compatible with that flow. We may need to add some logic to have the template not output the SLN if it doesn't work. |
Also double check the Web API , create, then context menu add orchestration |
OK that fixed it: "sources": [
{
"modifiers": [
{
"condition": "(hostIdentifier == \"vs\")",
"exclude": [
"*.sln"
]
}
]
}
],
...
"primaryOutputs": [
{
"path": "AspireApplication1.sln",
"condition": "(hostIdentifier != \"vs\")"
}, |
Good fix, best to just not write it at all for VS, unless we are doing solution folders or other customization. |
@phenning please approve if you're good with this change now |
I'm not sure what happened to this branch as it seems to have a bunch of other stuff in it now. I'm going to fix it all and resubmit. |
- Adds missing .sln files to templates so that they're created when creating projects from the CLI - Update the starter app template to be type "solution" (matching the empty template) - Add post-create task to restore packages when created from the CLI Fixes #21
ddaf9bc
to
3e515ad
Compare
Fixes #21
@phenning despite these changes, when using the starter app template in VS, it's still prompting for a project name and creating an extra directory under the solution directory. Is there something else that needs to be done to get it to work like the empty template? Both seem to be working as intended from the CLI after these changes.This was indeed template metadata caching causing the issue.