Dashboard dropdown max visible items #2678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
MatsM16
force-pushed
the
dashboard-dropdown-max-visible-items
branch
from
74df15b
to
b0a83e6
Compare
|
Rebased to latest |
JamesNK
approved these changes
Mar 6, 2024
src/Aspire.Dashboard/Components/Controls/ResourceSelect.razor.cs
Outdated
Show resolved
Hide resolved
src/Aspire.Dashboard/Components/Controls/ResourceSelect.razor.cs
Outdated
Show resolved
Hide resolved
JamesNK
reviewed
Mar 6, 2024
src/Aspire.Dashboard/Components/Controls/ResourceSelect.razor.cs
Outdated
Show resolved
Hide resolved
JamesNK
reviewed
Mar 6, 2024
src/Aspire.Dashboard/Components/Controls/ResourceSelect.razor.cs
Outdated
Show resolved
Hide resolved
JamesNK
reviewed
Mar 6, 2024
src/Aspire.Dashboard/Components/Controls/ResourceSelect.razor.cs
Outdated
Show resolved
Hide resolved
|
I added a little more to the height to take into account padding. Will merge. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResourceSelect10items.9 or less items in the dropdown:
The popup scales to fit the items.
10 items in the dropdown:
The popup has scaled to its maximum size, but will not show a scrollbar
11 or more items in the dropdown:
The popup has scaled to its maximum size and shows a scrollbar.
Microsoft Reviewers: Open in CodeFlow