Rename level to logLevel #2654
Merged
Rename level to logLevel #2654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlmii
approved these changes
Mar 5, 2024
kvenkatrajan
approved these changes
Mar 5, 2024
|
Are we going to have any tests for this stuff in the future? I worry about our ability to avoid regressions |
|
But when I changed all the URL generation and added tests was when it regressed. This shouldn't happen now that there is a baseline. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2650
in #2605 the parameter
levelwas changed tologLevel, this makes us read the right parameter name on page loadMicrosoft Reviewers: Open in CodeFlow