Add EndpointAnnotation directly in AddProject

[BrennanConroy]

Closes #2472

Microsoft Reviewers: Open in CodeFlow

[davidfowl]

you can't exclude launch settings later in your code since it's now done inline in AddProject

This seems like a good tradeoff.

specifying a specific launch settings to use via WithLaunchProfile doesn't work (add another param to AddProject?!)

I think this should be the same pattern yes, another parameter. Though I think maybe just a single argument launchProfile.

previous WithEndpoint calls that added an endpoint might not work the same now

Explain?

[davidfowl]

Let's move forward with this approach.

[davidfowl]

To clarify, the change is to make launchProfile processing part of the call to AddProject.

// Use the default launch profile (first one)
builder.AddProject<Projects.Api>("api");

// Pick a specific launch profile
builder.AddProject<Projects.Api>("api", launchProfile: "http");

// No launch profile
builder.AddProject<Projects.Api>("api", launchProfile: null);

cc @DamianEdwards

[DamianEdwards]

Assuming the default behavior is maintained this looks good

[BrennanConroy]

So we add a new overload with launchProfile as a required param on AddProject and a null value is equal to ExcludeLaunchProfile? And we keep the current overloads which grab the default launch profile?

[davidfowl]

So we add a new overload with launchProfile as a required param on AddProject and a null value is equal to ExcludeLaunchProfile? And we keep the current overloads which grab the default launch profile?

Yep and we deprecate WithLaunchProfile and ExcludeLaunchProfile the other overloads. I updated #2579 (comment)

[mitchdenny]

Looks good overall. One question for clarification and suggest a timeframe in the obsolete messages. I'm assuming you'll address David's feedback too but overall this looks good. Send it!