Make more things async #2533
Merged
Make more things async #2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-app-model
- Environment callbacks - Added GetConnectionStringAsync - Updated all of the tests
davidfowl
force-pushed
the
davidfowl/async-app-model
branch
from
4daf001
to
292a1ad
Compare
- Renamed ExecutableArgsCallbackAnnotation to CommandLineArgsCallbackAnnotation - Made everything async
mitchdenny
approved these changes
Feb 29, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
JamesNK
reviewed
Feb 29, 2024
playground/CustomResources/CustomResources.AppHost/TestResource.cs
Outdated
Show resolved
Hide resolved
src/Aspire.Hosting/ApplicationModel/CommandLineArgsCallbackAnnotation.cs
Outdated
Show resolved
Hide resolved
src/Aspire.Hosting/ApplicationModel/CustomResourceExtensions.cs
Outdated
Show resolved
Hide resolved
src/Aspire.Hosting/ApplicationModel/ResourceUpdatesAnnotation.cs
Outdated
Show resolved
Hide resolved
src/Aspire.Hosting/ApplicationModel/ResourceUpdatesAnnotation.cs
Outdated
Show resolved
Hide resolved
JamesNK
approved these changes
Feb 29, 2024
| @@ -17,14 +17,27 @@ public static class CustomResourceExtensions | |||
| /// <param name="builder">The resource builder.</param> | |||
| /// <param name="initialSnapshotFactory">The factory to create the initial <see cref="CustomResourceSnapshot"/> for this resource.</param> | |||
| /// <returns>The resource builder.</returns> | |||
| public static IResourceBuilder<TResource> WithResourceUpdates<TResource>(this IResourceBuilder<TResource> builder, Func<CustomResourceSnapshot>? initialSnapshotFactory = null) | |||
| public static IResourceBuilder<TResource> WithResourceUpdates<TResource>(this IResourceBuilder<TResource> builder, Func<CancellationToken, ValueTask<CustomResourceSnapshot>>? initialSnapshotFactory = null) | |||
There was a problem hiding this comment.
Having a context here would reduce the chance of needing something extra in the future causing a breaking change. Up to you.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is preparation for making it possible for resources to wait for a longer time for things like connection strings to be resolved. e.g. in the case of azure provisioning.
Microsoft Reviewers: Open in CodeFlow