Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename WithVolumeMount to WithVolume #2532

Merged
merged 1 commit into from
Feb 29, 2024
Merged

Rename WithVolumeMount to WithVolume #2532

merged 1 commit into from
Feb 29, 2024

Conversation

JamesNK
Copy link
Member

@JamesNK JamesNK commented Feb 29, 2024

Fixes #2528

Microsoft Reviewers: Open in CodeFlow

@JamesNK JamesNK added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Feb 29, 2024
@mitchdenny mitchdenny changed the title Rename AddVolumeMount to AddVolume Rename WithVolumeMount to WithVolume Feb 29, 2024
@mitchdenny
Copy link
Member

Approving because I'm assuming that the cloud-specific API surfaces will allow us to address the need for defining volumes in production deployments for compute workloads.

@JamesNK JamesNK merged commit 55d081d into main Feb 29, 2024
8 checks passed
@JamesNK JamesNK deleted the jamesnk/addvolume branch February 29, 2024 12:33
@github-actions github-actions bot locked and limited conversation to collaborators Apr 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider renaming WithVolumeMount to WithVolume
3 participants