Use RBAC and bicep provisioning for Azure OpenAI #2529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-app-model
|
Couldn't test E2E right now as it blocks on quotas. Won't merge before this is resolved. |
sebastienros
force-pushed
the
sebros/openairbac
branch
from
48f7126
to
73a0715
Compare
davidfowl
reviewed
Mar 2, 2024
eerhardt
reviewed
Mar 4, 2024
eerhardt
reviewed
Mar 4, 2024
eerhardt
reviewed
Mar 4, 2024
eerhardt
reviewed
Mar 4, 2024
davidfowl
reviewed
Mar 4, 2024
playground/OpenAIEndToEnd/OpenAIEndToEnd.AppHost/OpenAIEndToEnd.AppHost.csproj
Outdated
Show resolved
Hide resolved
davidfowl
reviewed
Mar 4, 2024
eerhardt
reviewed
Mar 4, 2024
# Conflicts: # src/Aspire.Hosting.Azure/AzureOpenAIResource.cs
|
Looks good. |
davidfowl
approved these changes
Mar 5, 2024
eerhardt
approved these changes
Mar 5, 2024
| /// <param name="modelVersion">The version of the model.</param> | ||
| /// <param name="skuName">The name of the SKU.</param> | ||
| /// <param name="skuCapacity">The capacity of the SKU.</param> | ||
| public class AzureOpenAIDeployment(string name, string modelName, string modelVersion, string skuName = "Standard", int skuCapacity = 2) |
There was a problem hiding this comment.
Is Standard and 2 applicable for all deployment models?
There was a problem hiding this comment.
Yes for Standard. I updated the default capacity to 1 and updated the bicep file to require the values from the app model. There are other options that could be set (capacity) but I assume we don't want to support all possible options or this would be the SDK.
eerhardt
reviewed
Mar 5, 2024
| @@ -73,3 +70,6 @@ resource cognitiveServiceContributorRoleAssignment 'Microsoft.Authorization/role | |||
| } | |||
|
|
|||
| output connectionString string = 'Endpoint=${account.properties.endpoint}' | |||
|
|
|||
|
|
|||
| output connectionString string = 'Endpoint=${account.properties.endpoint}' | |||
There was a problem hiding this comment.
Snap, mean automerger ... It got generated with the tool, not sure why. When looking at the diff locally I thought it was just adding a new line. Will fix it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2490
Microsoft Reviewers: Open in CodeFlow