Move reference of Aspire.Hosting into templates #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
approved these changes
Oct 11, 2023
|
Putting this up to address the feedback from @davidfowl. My 2 cents on this, is that we should probably keep the reference in the SDK as the default scenario, and just have people that want to control the packageref to have it explicit in their projects. I think we are hitting this everywhere now mostly because of how fast we are changing things, but I expect this won't be the case for customers, so it would be good to have a default case for them which doesn't involve requiring references in their projects. |
mitchdenny
reviewed
Oct 11, 2023
...es/aspire-starter/AspireStarterApplication1.AppHost/AspireStarterApplication1.AppHost.csproj
Show resolved
Hide resolved
|
FWIW, I've built the new workload locally after these changes, and I was able to create, build and run the aspire template. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126
cc: @davidfowl @dbreshears @danegsta @DamianEdwards
This is removing the reference to the Hosting package from the SDK targets and into the templates instead.