Use application name for dashboard page title #208
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidfowl
reviewed
Oct 10, 2023
|
|
smitpatel
force-pushed
the
smit/appname
branch
from
8a6da08
to
aac9d7a
Compare
eerhardt
reviewed
Oct 11, 2023
Comment on lines
+264
to
+267
| if (applicationName.EndsWith(AppHostSuffix, StringComparison.OrdinalIgnoreCase)) | ||
| { | ||
| applicationName = applicationName[..^AppHostSuffix.Length]; | ||
| } |
There was a problem hiding this comment.
We could do this down at the DistributedApplication level in Aspire.Hosting. That would seem like the better place for this logic.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #153