Null is not true, but null is not false #2030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
the
area-app-model
|
/backport to release/8.0-preview3 |
|
Started backporting to release/8.0-preview3: https://github.com/dotnet/aspire/actions/runs/7736840583 |
|
@davidfowl backporting to release/8.0-preview3 failed, the patch most likely resulted in conflicts: $ git am --3way --ignore-whitespace --keep-non-patch changes.patch
Applying: Null is not true, but null is not false
Using index info to reconstruct a base tree...
M src/Aspire.Hosting/Dcp/ApplicationExecutor.cs
Falling back to patching base and 3-way merge...
Auto-merging src/Aspire.Hosting/Dcp/ApplicationExecutor.cs
CONFLICT (content): Merge conflict in src/Aspire.Hosting/Dcp/ApplicationExecutor.cs
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Null is not true, but null is not false
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
|
@davidfowl an error occurred while backporting to release/8.0-preview3, please check the run log for details! Error: git am failed, most likely due to a merge conflict. |
joperezr
approved these changes
Feb 1, 2024
|
I was just discussing this with @JamesNK. To enable testing this component it needs a lot more refactoring. Yes, though we need to do it. |
|
I think we probably need to start to break |
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Feb 2, 2024
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Feb 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplest fix for this so we can backport to preview 3. A better fix is to avoid making this nullable and just have true and false 😄
Microsoft Reviewers: Open in CodeFlow