Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move SB metadata to intermediates #2023

Merged
merged 1 commit into from
Feb 1, 2024
Merged

Move SB metadata to intermediates #2023

merged 1 commit into from
Feb 1, 2024

Conversation

ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented Jan 31, 2024 •
edited by dotnet-policy-service bot
Loading

The changes in this pull request aim to improve the UX and guideance around the SourceBuild metadata by placing the metadata on explicit source-build intermediates.

The changes include:

  • Removing existing SourceBuild metadata from all non-intermediate dependencies.
  • Defining new explicit intermediate dependencies and adding SourceBuild metadata to those dependencies.

Related to dotnet/source-build#3373 and dotnet/source-build#4073

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-codeflow for labeling automated codeflow. intentionally a different color! label Jan 31, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 31, 2024
@ellahathaway ellahathaway mentioned this pull request Jan 31, 2024
Closed
@joperezr
Copy link
Member

joperezr commented Feb 1, 2024

Changes look good to me but not an expert in source build, so would be good to get @MichaelSimons sign off here.

joperezr
joperezr approved these changes Feb 1, 2024
View reviewed changes
Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MichaelSimons and @ellahathaway

@joperezr joperezr merged commit 0d7749b into dotnet:main Feb 1, 2024
8 checks passed
@ellahathaway ellahathaway deleted the sb-metadata branch February 1, 2024 18:54
radical pushed a commit to radical/aspire that referenced this pull request Feb 2, 2024
@ellahathaway @radical
Move SB metadata to intermediates (dotnet#2023)
9688974
radical pushed a commit to radical/aspire that referenced this pull request Feb 6, 2024
@ellahathaway @radical
Move SB metadata to intermediates (dotnet#2023)
47add7b
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joperezr joperezr joperezr approved these changes

@MichaelSimons MichaelSimons MichaelSimons approved these changes

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow. intentionally a different color! community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ellahathaway @joperezr @MichaelSimons