Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect logging parameter order in LogInformation call #201

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Fix incorrect logging parameter order in LogInformation call #201

merged 1 commit into from
Oct 10, 2023

Conversation

normj
Copy link
Contributor

@normj normj commented Oct 10, 2023

While reading through code to understand how the project works I noticed this LogInformation call looked like it has its log parameters in the incorrect order.

@davidfowl
Copy link
Member

Thanks for fixing my bugs @normj 😄

@davidfowl davidfowl merged commit eecb223 into dotnet:main Oct 10, 2023
4 checks passed
@normj normj deleted the normj/fix-logging-typo branch October 10, 2023 18:33
@danmoseley danmoseley added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Nov 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@smitpatel smitpatel smitpatel approved these changes

Assignees
No one assigned
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@normj @davidfowl @smitpatel @danmoseley