Use HashSet for constant time perf #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `PrepareServices` method calls `GenerateUniqueServiceName` for every annotation of every service producer. The previous `Contains` call is O(N) on the number of resources. This changes the `List<>` to a `HashSet<>` for more even perf across differing numbers of resources.
drewnoakes
added
the
area-app-model
davidfowl
approved these changes
Jan 31, 2024
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Feb 2, 2024
The `PrepareServices` method calls `GenerateUniqueServiceName` for every annotation of every service producer. The previous `Contains` call is O(N) on the number of resources. This changes the `List<>` to a `HashSet<>` for more even perf across differing numbers of resources.
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Feb 6, 2024
The `PrepareServices` method calls `GenerateUniqueServiceName` for every annotation of every service producer. The previous `Contains` call is O(N) on the number of resources. This changes the `List<>` to a `HashSet<>` for more even perf across differing numbers of resources.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
PrepareServicesmethod callsGenerateUniqueServiceNamefor every annotation of every service producer. The previousContainscall is O(N) on the number of resources.This changes the
List<>to aHashSet<>for more even perf across differing numbers of resources.Microsoft Reviewers: Open in CodeFlow