Add a known property for a resource's exit code #1998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exit code is a common property across resources in the UI. The UI will only show it when it has a non-null value. When the value is present, it should be visible without needing to click "show all".
JamesNK
approved these changes
Jan 31, 2024
drewnoakes
force-pushed
the
add-exit-code-known-property
branch
from
4f59402
to
f919bbf
Compare
The original issue is containers are displaying a -1 exit code while the container is running. That will need to be addressed, otherwise -1 will be displayed for all containers. Previously the problem was hidden away, but a known property will make it obvious. |
|
#1999 👍 |
|
I broke this up into a few logical changes to make review easier. Only one is marked as a fix. This just "relates to" that issue. |
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Feb 2, 2024
Exit code is a common property across resources in the UI. The UI will only show it when it has a non-null value. When the value is present, it should be visible without needing to click "show all".
radical
pushed a commit
to radical/aspire
that referenced
this pull request
Feb 6, 2024
Exit code is a common property across resources in the UI. The UI will only show it when it has a non-null value. When the value is present, it should be visible without needing to click "show all".
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1641
Exit code is a common property across resources in the UI. The UI will only show it when it has a non-null value. When the value is present, it should be visible without needing to click "show all".
Microsoft Reviewers: Open in CodeFlow