Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Mongo's AddDatabase() method #1987

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Update to Mongo's AddDatabase() method #1987

merged 1 commit into from
Jan 31, 2024

Conversation

Banovvv
Copy link
Contributor

@Banovvv Banovvv commented Jan 30, 2024 •
edited by dotnet-policy-service bot
Loading

The AddDatabase() method is currently an extension method on IResourceBuilder<MongoDBContainerResource> and cannot be used after AddMongoDB() which returns IResourceBuilder<MongoDBServerResource> instance. If AddDatabase() is made an extension method on IResourceBuilder<IMongoDBParentResource> it will be usable after both AddMongoDBContainer() and AddMongoDB().

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication label Jan 30, 2024
@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jan 30, 2024
eerhardt
eerhardt approved these changes Jan 30, 2024
View reviewed changes
Copy link
Member

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

cc @mitchdenny

mitchdenny
mitchdenny approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@mitchdenny mitchdenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll be consolidating these in P4 :) But the PR looks fine.

@davidfowl
Copy link
Member

I was so confused when building the mongo example why there was no add database

@davidfowl davidfowl merged commit ed11c48 into dotnet:main Jan 31, 2024
8 checks passed
radical pushed a commit to radical/aspire that referenced this pull request Feb 2, 2024
@Banovvv @radical
Update to Mongo's AddDatabase() method (dotnet#1987)
212263a
radical pushed a commit to radical/aspire that referenced this pull request Feb 6, 2024
@Banovvv @radical
Update to Mongo's AddDatabase() method (dotnet#1987)
6ac4e67
@github-actions github-actions bot locked and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@eerhardt eerhardt eerhardt approved these changes

@mitchdenny mitchdenny mitchdenny approved these changes

Assignees
No one assigned
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Banovvv @davidfowl @mitchdenny @eerhardt