Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AWS CloudFormation Provisioning and SDK Configuration #1905
Add AWS CloudFormation Provisioning and SDK Configuration #1905
Changes from 13 commits
b79ba3f
61ea393
c4724b9
bc5cbac
1b3af50
839a68a
e1fc1cb
708c32e
3a9159b
56c12f7
a21c441
ff67ca4
88bbe5b
162b3bf
7a1c8f9
73b6761
53494e5
12468ae
b8a5e7e
ee17fa2
411d32a
46e4917
b28f102
dd93d1f
f9093ab
f67fb5f
c9f4744
b72ea36
21b0f89
0b39eea
5198bcc
40a590d
46ec9d1
106f5a1
a316cf7
8f242c4
9c1756b
4cc515a
2ecd5ba
b8dc8d3
e4cd5bb
8e33322
dae3f4a
b3470f1
2ef50f1
79f6f6b
dc4cf58
e2947f8
ba86f69
39907b5
3492fcd
9ac29a0
eaea240
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great to get these packages added to the Aspire NuGet feeds. Some of these are newer versions of packages that are already in there. Currently I'm testing with hacking the
NuGet.config
to allow the public NuGet feed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these the versions you need?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to use the "hack" while the PR was in draft, and adding more dependencies? (and possibly updating new versions that are released). Then once the PR is ready for review, we can revert the nuget.config change, and mirror the necessary packages to the trusted feed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the AWS .NET SDK Otel provider. Wonder how a component could possible add it without access to the TracerProviderBuilder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Multiple calls to
AddOpenTelemetry().WithTracing(t => ...)
compose. This is what our aspire components do.